tools/perf/benchmarks/page_cycler_v2.py - Issue 2049593002: [PCv2] Add tracing category needed for computing ttfmp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2049593002: [PCv2] Add tracing category needed for computing ttfmp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use AddDisabledByDefault Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/page_cycler_v2.py

diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py

index 9678adee5e4928f9fb8260ee5138536d3612517f..ac220af4a720158a3c8f1c2934f06b463a435ddc 100644

--- a/tools/perf/benchmarks/page_cycler_v2.py

+++ b/tools/perf/benchmarks/page_cycler_v2.py

@@ -22,6 +22,10 @@ class _PageCyclerV2(perf_benchmark.PerfBenchmark):

cat_filter = tracing_category_filter.TracingCategoryFilter(

filter_string='blink.console,navigation,blink.user_timing,loading')

+ # Below categories are needed for first-meaningful-paint computation.

+ cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout')

+ cat_filter.AddIncludedCategory('devtools.timeline')

tbm_options = timeline_based_measurement.Options(

overhead_level=cat_filter)

tbm_options.SetTimelineBasedMetric('firstPaintMetric')

« no previous file with comments | « no previous file | no next file » | no next file with comments »