Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2049563002: [Third Party] Add ow2-asm jars to Chromium. (Closed)

Created:
4 years, 6 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Third Party] Add ow2-asm jars to Chromium. These jars are dependencies for Robolectric 3.0. BUG=522043 Committed: https://crrev.com/0466de340a7a064c46bff03dbf2da2024342de32 Cr-Commit-Position: refs/heads/master@{#403276}

Patch Set 1 #

Patch Set 2 : Fix script path. #

Patch Set 3 : Fix .sha1 file format. #

Patch Set 4 : Updated DEPS file. #

Total comments: 2

Patch Set 5 : Fixed README wording #

Patch Set 6 : Changed - to _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M .gitignore View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/ow2_asm/BUILD.gn View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/ow2_asm/LICENSE View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/ow2_asm/OWNERS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/ow2_asm/README.chromium View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/ow2_asm/lib/asm-5.0.1.jar.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/ow2_asm/lib/asm-analysis-5.0.1.jar.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/ow2_asm/lib/asm-commons-5.0.1.jar.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/ow2_asm/lib/asm-tree-5.0.1.jar.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/ow2_asm/lib/asm-util-5.0.1.jar.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
mikecase (-- gone --)
4 years, 6 months ago (2016-06-07 23:34:01 UTC) #2
mikecase (-- gone --)
+klobag for third_party/ review Got open-source approval via email. Tested running "gclient runhooks" locally. This ...
4 years, 6 months ago (2016-06-22 21:24:57 UTC) #4
the real yoland
lgtm
4 years, 6 months ago (2016-06-22 21:27:42 UTC) #5
jbudorick
lgtm w/ nit https://codereview.chromium.org/2049563002/diff/60001/third_party/ow2-asm/README.chromium File third_party/ow2-asm/README.chromium (right): https://codereview.chromium.org/2049563002/diff/60001/third_party/ow2-asm/README.chromium#newcode7 third_party/ow2-asm/README.chromium:7: Description: ASM is an Java bytecode ...
4 years, 5 months ago (2016-06-27 13:21:57 UTC) #6
jbudorick
On 2016/06/27 13:21:57, jbudorick (EMEA til June 30) wrote: > lgtm w/ nit > > ...
4 years, 5 months ago (2016-06-27 13:27:18 UTC) #7
mikecase (-- gone --)
https://codereview.chromium.org/2049563002/diff/60001/third_party/ow2-asm/README.chromium File third_party/ow2-asm/README.chromium (right): https://codereview.chromium.org/2049563002/diff/60001/third_party/ow2-asm/README.chromium#newcode7 third_party/ow2-asm/README.chromium:7: Description: ASM is an Java bytecode manipulation an analysis ...
4 years, 5 months ago (2016-06-27 17:24:42 UTC) #8
klobag.chromium
lgtm
4 years, 5 months ago (2016-06-29 18:28:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2049563002/100001
4 years, 5 months ago (2016-06-30 16:45:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/194890)
4 years, 5 months ago (2016-06-30 17:37:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2049563002/100001
4 years, 5 months ago (2016-06-30 20:07:11 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-30 20:45:30 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:45:32 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:47:46 UTC) #20
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/0466de340a7a064c46bff03dbf2da2024342de32
Cr-Commit-Position: refs/heads/master@{#403276}

Powered by Google App Engine
This is Rietveld 408576698