Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2049553002: check that Class and typedef refs are const (Closed)

Created:
4 years, 6 months ago by Harry Terkelsen
Modified:
4 years, 6 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

check that Class and typedef refs are const Fixes #26580 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/8a6a6377e7633d23d8a944d6555732dc0a06cdc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +8 lines, -11 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 6 months ago (2016-06-07 22:58:03 UTC) #2
Harry Terkelsen
ping
4 years, 6 months ago (2016-06-08 21:20:22 UTC) #3
sra1
lgtm
4 years, 6 months ago (2016-06-08 22:25:24 UTC) #4
Harry Terkelsen
4 years, 6 months ago (2016-06-08 23:03:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a6a6377e7633d23d8a944d6555732dc0a06cdc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698