Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2049543003: Make some profile-related prefs non-syncable on mobile. (Closed)

Created:
4 years, 6 months ago by anthonyvd
Modified:
4 years, 6 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some profile-related prefs non-syncable on mobile. BUG=618311 Committed: https://crrev.com/9426caf576f97a71a683acf94f113107f4fc79e9 Cr-Commit-Position: refs/heads/master@{#400682}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/profiles/profile_impl.cc View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
anthonyvd
Hi Mike, can you please take a look at this small change when you get ...
4 years, 6 months ago (2016-06-09 14:10:22 UTC) #2
Mike Lerman
lgtm
4 years, 6 months ago (2016-06-20 00:31:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049543003/20001
4 years, 6 months ago (2016-06-20 13:59:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 15:14:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049543003/20001
4 years, 6 months ago (2016-06-20 15:16:38 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 15:37:11 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:40:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9426caf576f97a71a683acf94f113107f4fc79e9
Cr-Commit-Position: refs/heads/master@{#400682}

Powered by Google App Engine
This is Rietveld 408576698