Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2049543002: [Third Party] Add icu4java to Chromium. (Closed)

Created:
4 years, 6 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Third Party] Add icu4java to Chromium. This jar is a dependency for Robolectric 3.0 BUG=522043 Committed: https://crrev.com/7529ab4476278d0754de6f808a82c575d6ceb961 Cr-Commit-Position: refs/heads/master@{#403283}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix script path. #

Patch Set 4 : Updated DEPS file. #

Total comments: 2

Patch Set 5 : changed icu4java to icu4j #

Patch Set 6 : [Third Party] Add icu4java to Chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -0 lines) Patch
M .gitignore View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/icu4j/BUILD.gn View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/icu4j/LICENSE View 1 2 3 4 1 chunk +412 lines, -0 lines 0 comments Download
A third_party/icu4j/OWNERS View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/icu4j/README.chromium View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/icu4j/lib/icu4j-53.1.jar.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
mikecase (-- gone --)
4 years, 6 months ago (2016-06-07 23:33:52 UTC) #2
mikecase (-- gone --)
+klobag for third_party/ review Got open-source approval via email. Tested running "gclient runhooks" locally. This ...
4 years, 6 months ago (2016-06-22 21:22:45 UTC) #4
the real yoland
lgtm
4 years, 6 months ago (2016-06-22 21:36:05 UTC) #5
the real yoland
https://codereview.chromium.org/2049543002/diff/60001/third_party/icu4java/BUILD.gn File third_party/icu4java/BUILD.gn (right): https://codereview.chromium.org/2049543002/diff/60001/third_party/icu4java/BUILD.gn#newcode7 third_party/icu4java/BUILD.gn:7: java_prebuilt("icu4java_java") { Nits, icu4_java?
4 years, 6 months ago (2016-06-22 21:51:52 UTC) #6
jbudorick
lgtm https://codereview.chromium.org/2049543002/diff/60001/third_party/icu4java/BUILD.gn File third_party/icu4java/BUILD.gn (right): https://codereview.chromium.org/2049543002/diff/60001/third_party/icu4java/BUILD.gn#newcode7 third_party/icu4java/BUILD.gn:7: java_prebuilt("icu4java_java") { On 2016/06/22 21:51:52, the real yoland ...
4 years, 5 months ago (2016-06-27 13:15:39 UTC) #7
Yoland Yan(Google)
On 2016/06/27 at 13:15:39, jbudorick wrote: > lgtm > > https://codereview.chromium.org/2049543002/diff/60001/third_party/icu4java/BUILD.gn > File third_party/icu4java/BUILD.gn (right): ...
4 years, 5 months ago (2016-06-27 16:12:08 UTC) #8
Yoland Yan(Google)
On 2016/06/27 at 16:12:08, Yoland Yan(Google) wrote: > On 2016/06/27 at 13:15:39, jbudorick wrote: > ...
4 years, 5 months ago (2016-06-27 16:12:20 UTC) #9
jbudorick
On 2016/06/27 16:12:20, Yoland Yan(Google) wrote: > On 2016/06/27 at 16:12:08, Yoland Yan(Google) wrote: > ...
4 years, 5 months ago (2016-06-27 16:14:41 UTC) #10
mikecase (-- gone --)
On 2016/06/27 at 16:14:41, jbudorick wrote: > On 2016/06/27 16:12:20, Yoland Yan(Google) wrote: > > ...
4 years, 5 months ago (2016-06-27 17:10:04 UTC) #11
klobag.chromium
lgtm
4 years, 5 months ago (2016-06-29 18:27:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2049543002/100001
4 years, 5 months ago (2016-06-30 16:45:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/238458)
4 years, 5 months ago (2016-06-30 17:40:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2049543002/100001
4 years, 5 months ago (2016-06-30 20:07:10 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-30 21:04:53 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 21:05:02 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:07:09 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7529ab4476278d0754de6f808a82c575d6ceb961
Cr-Commit-Position: refs/heads/master@{#403283}

Powered by Google App Engine
This is Rietveld 408576698