Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2049513002: To M51: MSE, MS, and any blob URL: Ignore preload 'none' on resource fetching

Created:
4 years, 6 months ago by wolenetz
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

To M51: MSE, MS, and any blob URL: Ignore preload 'none' on resource fetching M51 didn't include MediaStream srcObject support, so this cherry-pick involves merge conflict resolution to retain the intent of the M52 version, absent the MediaStream srcObject support. Prevents the usage of the optional resource fetch algorithm steps for when preload='none' in the MSE, MediaStream, or any blob URL cases. Complies with recent update to MSE spec [1] and fixes the related crbug.com/539707. Includes test coverage for MSE and invalid (revoked MSE object) blob URLs. MediaStream test coverage is expected to come from later import of a new web-platform-tests [2]. [1] https://github.com/w3c/media-source/pull/64 [2] https://github.com/w3c/web-platform-tests/pull/2895 R=guidou@chromium.org TBR=foolip@chromium.or,srirama.m@samsung.com BUG=539707 TEST=http/tests/media/media-source/mediasource-preload.html Review URL: https://codereview.chromium.org/1881733004 Cr-Commit-Position: refs/heads/master@{#389649} (cherry picked from commit b16f202aa67513f74576312f7f8a3ad17f60458a)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-preload.html View 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wolenetz
guidou@: Please take a look. I believe I've resolved the merge conflicts appropriately to retain ...
4 years, 6 months ago (2016-06-07 21:35:14 UTC) #2
Guido Urdaneta
On 2016/06/07 21:35:14, wolenetz_slow_reviews wrote: > guidou@: Please take a look. I believe I've resolved ...
4 years, 6 months ago (2016-06-08 09:31:12 UTC) #3
Srirama
LGTM but what about the cleanup done in https://codereview.chromium.org/1920383002/ ?
4 years, 6 months ago (2016-06-08 12:11:51 UTC) #4
wolenetz
On 2016/06/08 12:11:51, Srirama wrote: > LGTM but what about the cleanup done in > ...
4 years, 6 months ago (2016-06-08 15:15:04 UTC) #5
foolip
4 years, 6 months ago (2016-06-09 11:22:09 UTC) #6
lgtm in case you need it.

Powered by Google App Engine
This is Rietveld 408576698