[Third Party] Add Apache-Velocity to Chromium

[Third Party] Add Apache-Velocity to Chromium

This jar is required to process Roboletric templated code.

BUG=522043
Committed: https://crrev.com/f0e1c4316f88153fe911ef08eac5879425f3488b
Cr-Commit-Position: refs/heads/master@{#403265}

[mikecase (-- gone --), 2016-06-07 23:33:40]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, yolandyan@chromium.org

[the real yoland, 2016-06-09 18:57:44]

https://codereview.chromium.org/2049503003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2049503003/diff/1/DEPS#newcode601
DEPS:601: 'src/build/android/update_third_party_deps.py',
same here,
`src/build/android/update_third_party_deps/update_third_party_deps.py` :(

[mikecase (-- gone --), 2016-06-22 21:21:42]

mikecase@chromium.org changed reviewers:
+ klobag@chromium.org

[mikecase (-- gone --), 2016-06-22 21:21:42]

+klobag for third_party/ review

Got open-source approval via email.
Tested running "gclient runhooks" locally.

This is a dependency for Robolectric 3.0

[the real yoland, 2016-06-22 21:53:03]

lgtm

[jbudorick, 2016-06-27 13:12:45]

lgtm

[jbudorick, 2016-06-27 13:18:36]

+nit

https://codereview.chromium.org/2049503003/diff/20001/third_party/apache-velo...
File third_party/apache-velocity/BUILD.gn (right):

https://codereview.chromium.org/2049503003/diff/20001/third_party/apache-velo...
third_party/apache-velocity/BUILD.gn:8: jar_path = "lib/velocity-1.7-dep.jar"
nit: testonly?

[mikecase (-- gone --), 2016-06-27 17:50:42]

also changed directory from apache-velocity to apache_velocity to be inline with
your comment on some other reviews.

https://codereview.chromium.org/2049503003/diff/20001/third_party/apache-velo...
File third_party/apache-velocity/BUILD.gn (right):

https://codereview.chromium.org/2049503003/diff/20001/third_party/apache-velo...
third_party/apache-velocity/BUILD.gn:8: jar_path = "lib/velocity-1.7-dep.jar"
On 2016/06/27 at 13:18:36, jbudorick (EMEA til June 30) wrote:
> nit: testonly?

Done

[klobag.chromium, 2016-06-29 18:29:26]

lgtm

[mikecase (-- gone --), 2016-06-30 16:45:47]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-06-30 16:45:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, yolandyan@chromium.org
Link to the patchset: https://codereview.chromium.org/2049503003/#ps40001
(title: "Changed - to _. Chaanged to testonly")

[commit-bot: I haz the power, 2016-06-30 16:46:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:51:52]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[mikecase (-- gone --), 2016-06-30 17:21:53]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:26:10]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[mikecase (-- gone --), 2016-06-30 20:06:42]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-06-30 20:07:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:14:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 20:16:40]

Description was changed from

==========
[Third Party] Add Apache-Velocity to Chromium

This jar is required to process Roboletric templated code.

BUG=522043
==========

to

==========
[Third Party] Add Apache-Velocity to Chromium

This jar is required to process Roboletric templated code.

BUG=522043

Committed: https://crrev.com/f0e1c4316f88153fe911ef08eac5879425f3488b
Cr-Commit-Position: refs/heads/master@{#403265}
==========

[commit-bot: I haz the power, 2016-06-30 20:16:41]

Patchset 3 (id:??) landed as
https://crrev.com/f0e1c4316f88153fe911ef08eac5879425f3488b
Cr-Commit-Position: refs/heads/master@{#403265}