reviewbot/model/app_config.py - Issue 20495003: Implement interface to Rietveld.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: reviewbot/model/app_config.py

Issue 20495003: Implement interface to Rietveld. (Closed) Base URL: https://src.chromium.org/chrome/trunk/tools/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from google.appengine.ext import ndb

	6

	7

	8 class AppConfig(ndb.Model):

	9 """Application configuration data."""

	10 client_id = ndb.TextProperty()

	11 service_account_key = ndb.TextProperty()

	12 server_url = ndb.TextProperty()

	13 nickname = ndb.TextProperty()

	14

	15

	16 def get():

	17 config = ndb.Key(AppConfig, 'config').get()

	18 if config is None:

	19 config = AppConfig(id = 'config')
	agable 2013/08/02 16:35:35 nit: no spaces around = in function calls and defi nit: no spaces around = in function calls and definitions. Mattias Nissler (ping if slow) 2013/08/05 09:08:51 Done. Show quoted text On 2013/08/02 16:35:35, Aaron Gable wrote: > nit: no spaces around = in function calls and definitions. Done. agable 2013/08/05 17:38:00 There are some other instances of this in rietveld Show quoted text On 2013/08/05 09:08:51, Mattias Nissler wrote: > On 2013/08/02 16:35:35, Aaron Gable wrote: > > nit: no spaces around = in function calls and definitions. > > Done. There are some other instances of this in rietveld.py Mattias Nissler (ping if slow) 2013/08/05 18:40:47 Fixed. (I'm surprised pylint doesn't catch those!) Show quoted text On 2013/08/05 17:38:00, Aaron Gable wrote: > On 2013/08/05 09:08:51, Mattias Nissler wrote: > > On 2013/08/02 16:35:35, Aaron Gable wrote: > > > nit: no spaces around = in function calls and definitions. > > > > Done. > > There are some other instances of this in rietveld.py Fixed. (I'm surprised pylint doesn't catch those!)
	20 return config

OLD	NEW

« reviewbot/model/app_config ('K') | « reviewbot/model/app_config ('k') | reviewbot/rietveld.py » ('j') | reviewbot/rietveld.py » ('J')