third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 2049493005: binding: Uses the relevant realm instead of the current realm (1 of ?)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 2049493005: binding: Uses the relevant realm instead of the current realm (1 of ?) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated layout tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptState.h ('K') | « third_party/WebKit/Source/bindings/templates/methods.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

index 4fee8f1ce28f0c3cdd3460917155556b9e73a4ee..74c73108cc396b36a15c4813752efc589676c5d2 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -1786,7 +1786,7 @@ static void toJSONMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "toJSON", "TestInterface", info.Holder(), info.GetIsolate());

TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());

- ScriptState* scriptState = ScriptState::current(info.GetIsolate());

+ ScriptState* scriptState = ScriptState::forThisObject(info);

ScriptValue result = impl->toJSONForBinding(scriptState, exceptionState);

if (exceptionState.hadException()) {

exceptionState.throwIfNeeded();

@@ -1815,7 +1815,7 @@ static void iteratorMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "iterator", "TestInterface", info.Holder(), info.GetIsolate());

TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());

- ScriptState* scriptState = ScriptState::current(info.GetIsolate());

+ ScriptState* scriptState = ScriptState::forThisObject(info);

Iterator* result = impl->iterator(scriptState, exceptionState);

if (exceptionState.hadException()) {

exceptionState.throwIfNeeded();