Issue 2049443002: Fix the //mojo/go:application target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2049443002: Fix the //mojo/go:application target. (Closed)

Created:
4 years, 6 months ago by viettrungluu

Modified:
4 years, 6 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix the //mojo/go:application target. * It was missing describer.go in its list of sources (so if you changed it, but nothing else caused the target to rebuild, you'd be unhappy). * It was missing dependencies on a couple of interface targets. R=azani@chromium.org BUG=fixes #792 Committed: https://chromium.googlesource.com/external/mojo/+/5e6754ba911667ba425291992e162284f142726a

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	mojo/go/BUILD.gn	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 6 months ago (2016-06-07 20:13:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e6754ba911667ba425291992e162284f142726a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages