Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: headless/public/headless_browser_context.h

Issue 2049363003: Adds support for headless chrome embedder mojo services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/renderer/headless_content_renderer_client.cc ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/headless_browser_context.h
diff --git a/headless/public/headless_browser_context.h b/headless/public/headless_browser_context.h
index f8c581c2fd5fb0a17cfce226cca63e9f380cdaff..165e12fc403157b03df9e327b2be561615502bd9 100644
--- a/headless/public/headless_browser_context.h
+++ b/headless/public/headless_browser_context.h
@@ -5,6 +5,8 @@
#ifndef HEADLESS_PUBLIC_HEADLESS_BROWSER_CONTEXT_H_
#define HEADLESS_PUBLIC_HEADLESS_BROWSER_CONTEXT_H_
+#include <list>
+
#include "headless/public/headless_export.h"
#include "net/url_request/url_request_job_factory.h"
@@ -32,6 +34,7 @@ class HEADLESS_EXPORT HeadlessBrowserContext {
DISALLOW_COPY_AND_ASSIGN(HeadlessBrowserContext);
};
+// TODO(alexclarke): We should support this builder for the default context.
class HEADLESS_EXPORT HeadlessBrowserContext::Builder {
public:
Builder(Builder&&);
@@ -41,15 +44,49 @@ class HEADLESS_EXPORT HeadlessBrowserContext::Builder {
// fetching for different network schemes.
Builder& SetProtocolHandlers(ProtocolHandlerMap protocol_handlers);
+ // Specify JS mojo module bindings to be installed, one per mojom file.
+ // Note a single mojom file could potentially define many interfaces.
+ // |mojom_name| the name including path of the .mojom file.
+ // |js_bindings| compiletime generated javascript bindings. Typically loaded
+ // from gen/path/name.mojom.js.
+ Builder& AddJsMojoBindings(const std::string& mojom_name,
+ const std::string& js_bindings);
+
+ // By default if you add mojo bindings, http and https are disabled because
+ // its almost certinly unsafe for arbitary sites on the internet to have
+ // access to these bindings. If you know what you're doing it may be OK to
+ // turn them back on. E.g. if headless_lib is being used in a testing
+ // framework which serves the web content from disk that's likely ok.
+ //
+ // That said, best pratice is to add a ProtocolHandler to serve the
+ // webcontent over a custom protocol. That way you can be sure that only the
+ // things you intend have access to mojo.
+ Builder& EnableUnsafeNetworkAccessWithMojoBindings(
+ bool enable_http_and_https_if_mojo_used);
+
std::unique_ptr<HeadlessBrowserContext> Build();
private:
friend class HeadlessBrowserImpl;
+ struct MojoBindings {
+ MojoBindings();
+ MojoBindings(const std::string& mojom_name, const std::string& js_bindings);
+ ~MojoBindings();
+
+ std::string mojom_name;
+ std::string js_bindings;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MojoBindings);
+ };
+
explicit Builder(HeadlessBrowserImpl* browser);
HeadlessBrowserImpl* browser_;
ProtocolHandlerMap protocol_handlers_;
+ std::list<MojoBindings> mojo_bindings_;
+ bool enable_http_and_https_if_mojo_used_;
DISALLOW_COPY_AND_ASSIGN(Builder);
};
« no previous file with comments | « headless/lib/renderer/headless_content_renderer_client.cc ('k') | headless/public/headless_web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698