headless/test/data/page_one.html - Issue 2049363003: Adds support for headless chrome embedder mojo services

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: headless/test/data/page_one.html

Issue 2049363003: Adds support for headless chrome embedder mojo services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <head>

	3 <script>

	4

	5 mojo.services.embedder_test.TestEmbedderService.then(function(service) {

	6 service.returnTestResult("page one");

	7 window.location.pathname = "/page_two.html";
	Charlie Reis 2016/06/21 23:08:32 This probably won't exercise the bug, since it's n This probably won't exercise the bug, since it's not a cross-process navigation. (Did the test fail without the RenderFrameCreated fix?) Is there a way to make your test do a browser-initiated cross-site navigation instead? That would be cross-process. (There's also SetupCrossSiteRedirector which would let you link to /cross-site/foo.com/page_two.html, but that would be renderer-initiated and thus stay in the same process unless you run with --site-per-process.) alex clarke (OOO till 29th) 2016/06/22 10:04:00 No it didn't :) I've copied a trick used in one o Show quoted text On 2016/06/21 23:08:32, Charlie Reis wrote: > This probably won't exercise the bug, since it's not a cross-process navigation. > (Did the test fail without the RenderFrameCreated fix?) No it didn't :) I've copied a trick used in one of our other browser tests to fake a different TLD and I instrumented the code and can see that RenderFrameCreated is called twice and the bindings are installed twice. Show quoted text > > Is there a way to make your test do a browser-initiated cross-site navigation > instead? That would be cross-process. > > (There's also SetupCrossSiteRedirector which would let you link to > /cross-site/foo.com/page_two.html, but that would be renderer-initiated and thus > stay in the same process unless you run with --site-per-process.) Charlie Reis 2016/06/22 19:30:59 Great-- that looks better. Show quoted text On 2016/06/22 10:04:00, alex clarke wrote: > On 2016/06/21 23:08:32, Charlie Reis wrote: > > This probably won't exercise the bug, since it's not a cross-process > navigation. > > (Did the test fail without the RenderFrameCreated fix?) > > No it didn't :) > > I've copied a trick used in one of our other browser tests to fake a different > TLD and I instrumented the code and can see that RenderFrameCreated is called > twice and the bindings are installed twice. > > > > > > Is there a way to make your test do a browser-initiated cross-site navigation > > instead? That would be cross-process. > > > > (There's also SetupCrossSiteRedirector which would let you link to > > /cross-site/foo.com/page_two.html, but that would be renderer-initiated and > thus > > stay in the same process unless you run with --site-per-process.) > Great-- that looks better.
	8 });

	9

	10 </script>

	11 </head>

	12 <body><h1>Page one</h1></body>

OLD	NEW

« headless/lib/browser/headless_web_contents_impl.cc ('K') | « headless/test/data/mojo_test.html ('k') | headless/test/data/page_two.html » ('j') | no next file with comments »