Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 204933002: Fix crash introduced in https://codereview.chromium.org/179123002/ (Closed)

Created:
6 years, 9 months ago by Yaron
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix crash introduced in https://codereview.chromium.org/179123002/ We could have a dangling pointer if the RenderProcessHost is destroyed prior to the renderer going away while we have a suspended timer. This can happen in the case of an intent triggered from an external app since it reuses one tab, destroying the tab that was previously created by that app. This happens early during resume, before webkit timers are resumed. BUG=352213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258544

Patch Set 1 #

Patch Set 2 : rmoever override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/browser/android/content_view_statics.cc View 1 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yaron
6 years, 9 months ago (2014-03-19 18:36:33 UTC) #1
Yaron
bump
6 years, 9 months ago (2014-03-20 17:41:49 UTC) #2
Yaron
feng: can you take a look?
6 years, 9 months ago (2014-03-20 22:14:28 UTC) #3
Feng Qian
lgtm
6 years, 9 months ago (2014-03-21 00:20:49 UTC) #4
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 9 months ago (2014-03-21 00:25:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/204933002/20001
6 years, 9 months ago (2014-03-21 00:26:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 03:15:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-21 03:15:52 UTC) #8
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 9 months ago (2014-03-21 04:51:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/204933002/20001
6 years, 9 months ago (2014-03-21 04:51:51 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 12:20:27 UTC) #11
Message was sent while issue was closed.
Change committed as 258544

Powered by Google App Engine
This is Rietveld 408576698