Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: components/test_runner/event_sender.cc

Issue 2049323002: [Mac] Don't dispatch wheel events for PhaseMayBegin|Cancelled|Ended (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add filter and LayoutTests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/mouse-wheel-main-frame-event.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/event_sender.cc
diff --git a/components/test_runner/event_sender.cc b/components/test_runner/event_sender.cc
index be730ccc00809fa273ecd47071c9eb71d6e49259..231531dea7a428d77efdefd64a3cca7da65cfa7b 100644
--- a/components/test_runner/event_sender.cc
+++ b/components/test_runner/event_sender.cc
@@ -2540,6 +2540,7 @@ void EventSender::InitMouseWheelEvent(gin::Arguments* args,
bool paged = false;
bool has_precise_scrolling_deltas = false;
int modifiers = 0;
+ int phase = 0;
if (!args->PeekNext().IsEmpty()) {
args->GetNext(&paged);
if (!args->PeekNext().IsEmpty()) {
@@ -2550,6 +2551,9 @@ void EventSender::InitMouseWheelEvent(gin::Arguments* args,
modifiers = GetKeyModifiersFromV8(args->isolate(), value);
if (!args->PeekNext().IsEmpty()) {
args->GetNext(send_gestures);
+ if (!args->PeekNext().IsEmpty()) {
dtapuska 2016/06/30 19:53:00 This is kind of weird that we will cast a value fr
chongz 2016/07/04 14:12:36 Done.
+ args->GetNext(&phase);
+ }
}
}
}
@@ -2566,6 +2570,7 @@ void EventSender::InitMouseWheelEvent(gin::Arguments* args,
event->deltaY = event->wheelTicksY;
event->scrollByPage = paged;
event->hasPreciseScrollingDeltas = has_precise_scrolling_deltas;
+ event->phase = static_cast<WebMouseWheelEvent::Phase>(phase);
if (scroll_type == MouseScrollType::PIXEL) {
event->wheelTicksX /= kScrollbarPixelsPerTick;
event->wheelTicksY /= kScrollbarPixelsPerTick;
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/mouse-wheel-main-frame-event.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698