Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: components/safe_json/safe_json_parser_impl.h

Issue 2049303002: Add the UtilityProcessMojoClient class and convert SafeJsonParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed android sandbox browser tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/safe_json/safe_json_parser_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_ 5 #ifndef COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_
6 #define COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_ 6 #define COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "base/callback.h"
11 #include "base/macros.h" 12 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
13 #include "base/memory/weak_ptr.h"
14 #include "base/threading/thread_checker.h" 14 #include "base/threading/thread_checker.h"
15 #include "components/safe_json/public/interfaces/safe_json.mojom.h" 15 #include "components/safe_json/public/interfaces/safe_json.mojom.h"
16 #include "components/safe_json/safe_json_parser.h" 16 #include "components/safe_json/safe_json_parser.h"
17 #include "content/public/browser/utility_process_host_client.h" 17 #include "content/public/browser/utility_process_mojo_client.h"
18 18
19 namespace base { 19 namespace base {
20 class ListValue; 20 class ListValue;
21 class SequencedTaskRunner; 21 class SequencedTaskRunner;
22 class Value; 22 class Value;
23 } 23 }
24 24
25 namespace content {
26 class UtilityProcessHost;
27 }
28
29 namespace IPC {
30 class Message;
31 }
32
33 namespace safe_json { 25 namespace safe_json {
34 26
35 class SafeJsonParserImpl : public content::UtilityProcessHostClient, 27 class SafeJsonParserImpl : public SafeJsonParser {
36 public SafeJsonParser {
37 public: 28 public:
38 SafeJsonParserImpl(const std::string& unsafe_json, 29 SafeJsonParserImpl(const std::string& unsafe_json,
39 const SuccessCallback& success_callback, 30 const SuccessCallback& success_callback,
40 const ErrorCallback& error_callback); 31 const ErrorCallback& error_callback);
41 32
42 private: 33 private:
43 ~SafeJsonParserImpl() override; 34 ~SafeJsonParserImpl() override;
44 35
45 void StartWorkOnIOThread();
46
47 void ReportResults();
48 void ReportResultsOnOriginThread();
49
50 // Implementing pieces of the UtilityProcessHostClient interface.
51 bool OnMessageReceived(const IPC::Message& message) override;
52
53 // SafeJsonParser implementation. 36 // SafeJsonParser implementation.
54 void Start() override; 37 void Start() override;
55 38
39 void StartOnIOThread();
40 void OnConnectionError();
41
56 // mojom::SafeJsonParser::Parse callback. 42 // mojom::SafeJsonParser::Parse callback.
57 void OnParseDone(const base::ListValue& wrapper, mojo::String error); 43 void OnParseDone(const base::ListValue& wrapper, const mojo::String& error);
44
45 // Reports the result on the calling task runner via the |success_callback_|
46 // or the |error_callback_|.
47 void ReportResults(std::unique_ptr<base::Value> parsed_json,
48 const std::string& error);
58 49
59 const std::string unsafe_json_; 50 const std::string unsafe_json_;
60 SuccessCallback success_callback_; 51 SuccessCallback success_callback_;
61 ErrorCallback error_callback_; 52 ErrorCallback error_callback_;
62 scoped_refptr<base::SequencedTaskRunner> caller_task_runner_; 53 scoped_refptr<base::SequencedTaskRunner> caller_task_runner_;
63 54
64 std::unique_ptr<base::Value> parsed_json_; 55 std::unique_ptr<content::UtilityProcessMojoClient<mojom::SafeJsonParser>>
65 std::string error_; 56 mojo_json_parser_;
66 57
67 base::WeakPtr<content::UtilityProcessHost> utility_process_host_; 58 // Used instead of DCHECK_CURRENTLY_ON(BrowserThread::IO) because it's
68 59 // posssible that it fails when the IO thread message loop is shutting down.
69 mojom::SafeJsonParserPtr service_; 60 // This happens after the IO thread has unregistered from the BrowserThread
70 61 // list.
71 // To ensure the UtilityProcessHost and Mojo service are only accessed on the
72 // IO thread.
73 base::ThreadChecker io_thread_checker_; 62 base::ThreadChecker io_thread_checker_;
74 63
75 DISALLOW_COPY_AND_ASSIGN(SafeJsonParserImpl); 64 DISALLOW_COPY_AND_ASSIGN(SafeJsonParserImpl);
76 }; 65 };
77 66
78 } // namespace safe_json 67 } // namespace safe_json
79 68
80 #endif // COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_ 69 #endif // COMPONENTS_SAFE_JSON_SAFE_JSON_PARSER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | components/safe_json/safe_json_parser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698