Make sure CSS agent messages flush before testing.

Make sure CSS agent messages flush before testing.

While working on updating active stylesheets as part of the style and
layout tree update in [1], two inspector tests started failing. The
reason was these tests rely on a console message to trigger a step in
the test after the active stylesheets have been pushed to the inspector
client. But even if the stylesheets were updated in InspectorCSSAgent
before the console message was sent, the console message arrived in the
client before the new active stylesheets. The reason was that the
console message is immediately flushed, while the messages from the
InspectorCSSAgent are lazily flushed from WebDevToolsAgentImpl::
didProcessTask.

I tried to force the active stylesheet update with a forced layout tree
update like this:

  document.documentElement.offsetTop;
  console.log(...);

But, due the console.log message being dispatched first as described
above, I ended up postponing the console.log with a rAF which means it
will run in a later task and the didProcessTask will trigger in between
to flush the active stylesheet message(s).

Note that this was not currently causing any failures. It's done in
preparation for landing changes for 567021 without breaking anything.

Looking at TestExpectations, I noticed crbug.com/597572, which might be
a similar issue.

[1] https://codereview.chromium.org/1913833002/

R=pfeldman@chromium.org,dgozman@chromium.org
BUG=567021
Committed: https://crrev.com/debc55c49bd4a79870be6482bc4466971cdb5a1b
Cr-Commit-Position: refs/heads/master@{#398825}

[rune, 2016-06-08 21:17:25]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 21:18:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049283002/1

[rune, 2016-06-08 23:22:38]

ptal

[commit-bot: I haz the power, 2016-06-09 00:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 00:13:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-06-09 05:25:04]

lgtm

https://codereview.chromium.org/2049283002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resources/script-navigated.js
(right):

https://codereview.chromium.org/2049283002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resources/script-navigated.js:3:
requestAnimationFrame(() => {
We don't need a frame - all we need is a new task. setTimeout(, 0) would do.

For a real fix, we'd need to introduce a barrier that would trigger upon frame
load _and_ style recalc explicitly if we need recalc to be there.

[rune, 2016-06-09 08:15:15]

The CQ bit was checked by rune@opera.com

[rune, 2016-06-09 08:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2049283002/#ps20001
(title: "Use setTimeout")

[commit-bot: I haz the power, 2016-06-09 08:15:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049283002/20001

[commit-bot: I haz the power, 2016-06-09 09:34:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 09:36:14]

Description was changed from

==========
Make sure CSS agent messages flush before testing.

While working on updating active stylesheets as part of the style and
layout tree update in [1], two inspector tests started failing. The
reason was these tests rely on a console message to trigger a step in
the test after the active stylesheets have been pushed to the inspector
client. But even if the stylesheets were updated in InspectorCSSAgent
before the console message was sent, the console message arrived in the
client before the new active stylesheets. The reason was that the
console message is immediately flushed, while the messages from the
InspectorCSSAgent are lazily flushed from WebDevToolsAgentImpl::
didProcessTask.

I tried to force the active stylesheet update with a forced layout tree
update like this:

  document.documentElement.offsetTop;
  console.log(...);

But, due the console.log message being dispatched first as described
above, I ended up postponing the console.log with a rAF which means it
will run in a later task and the didProcessTask will trigger in between
to flush the active stylesheet message(s).

Note that this was not currently causing any failures. It's done in
preparation for landing changes for 567021 without breaking anything.

Looking at TestExpectations, I noticed crbug.com/597572, which might be
a similar issue.

[1] https://codereview.chromium.org/1913833002/

R=pfeldman@chromium.org,dgozman@chromium.org
BUG=567021
==========

to

==========
Make sure CSS agent messages flush before testing.

While working on updating active stylesheets as part of the style and
layout tree update in [1], two inspector tests started failing. The
reason was these tests rely on a console message to trigger a step in
the test after the active stylesheets have been pushed to the inspector
client. But even if the stylesheets were updated in InspectorCSSAgent
before the console message was sent, the console message arrived in the
client before the new active stylesheets. The reason was that the
console message is immediately flushed, while the messages from the
InspectorCSSAgent are lazily flushed from WebDevToolsAgentImpl::
didProcessTask.

I tried to force the active stylesheet update with a forced layout tree
update like this:

  document.documentElement.offsetTop;
  console.log(...);

But, due the console.log message being dispatched first as described
above, I ended up postponing the console.log with a rAF which means it
will run in a later task and the didProcessTask will trigger in between
to flush the active stylesheet message(s).

Note that this was not currently causing any failures. It's done in
preparation for landing changes for 567021 without breaking anything.

Looking at TestExpectations, I noticed crbug.com/597572, which might be
a similar issue.

[1] https://codereview.chromium.org/1913833002/

R=pfeldman@chromium.org,dgozman@chromium.org
BUG=567021

Committed: https://crrev.com/debc55c49bd4a79870be6482bc4466971cdb5a1b
Cr-Commit-Position: refs/heads/master@{#398825}
==========

[commit-bot: I haz the power, 2016-06-09 09:36:16]

Patchset 2 (id:??) landed as
https://crrev.com/debc55c49bd4a79870be6482bc4466971cdb5a1b
Cr-Commit-Position: refs/heads/master@{#398825}