Updating remoting_start_host to use remoting_core.dll

Updating remoting_start_host to use remoting_core.dll

The remoting_start_host binary is much larger than other exes in the Windows
MSI (~5MB vs. 100KB).  This is because it links in a bunch of code we
already include in remoting_core.dll.

This change moves the shared code into remoting_core.dll and sets up the
remoting_start_host binary to use a shared library for other platforms if we
decide to do so later on.  It also updates the information that is stamped on
the windows exe so it reflects the name and purpose of the tool.

BUG=617182
Committed: https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8
Cr-Commit-Position: refs/heads/master@{#398787}

[joedow, 2016-06-08 19:38:30]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org, zijiehe@chromium.org

[joedow, 2016-06-08 19:38:30]

joedow@chromium.org changed required reviewers:
+ sergeyu@chromium.org

[joedow, 2016-06-08 19:38:31]

PTAL!

Thanks,
Joe

[Hzj_jie, 2016-06-08 20:48:48]

https://codereview.chromium.org/2049173003/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2049173003/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:740: defines = [ "BINARY=BINARY_REMOTING_START_HOST" ]
You may want to append 'host_predefines' before this definition, and add
BINARY_REMOTING_START_HOST in host_predefines.

[Sergey Ulanov, 2016-06-08 21:47:10]

lgtm

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
File remoting/host/setup/start_host_main.cc (right):

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
remoting/host/setup/start_host_main.cc:36: using remoting::HostStarter;
Wouldn't need this if this code was inside remoting namespace

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
remoting/host/setup/start_host_main.cc:117: namespace remoting {
Move this before the anonymous namespace above, i.e.
namespace remoting {

namesoace {
..
}

int StartHostMain() {}

}

[joedow, 2016-06-08 23:37:03]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-06-08 23:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2049173003/#ps20001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2016-06-08 23:37:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049173003/20001

[commit-bot: I haz the power, 2016-06-09 03:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 03:01:02]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joedow, 2016-06-09 04:17:52]

Thanks!

https://codereview.chromium.org/2049173003/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/2049173003/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:740: defines = [ "BINARY=BINARY_REMOTING_START_HOST" ]
On 2016/06/08 20:48:48, Hzj_jie wrote:
> You may want to append 'host_predefines' before this definition, and add
> BINARY_REMOTING_START_HOST in host_predefines.

Done.

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
File remoting/host/setup/start_host_main.cc (right):

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
remoting/host/setup/start_host_main.cc:36: using remoting::HostStarter;
On 2016/06/08 21:47:10, Sergey Ulanov wrote:
> Wouldn't need this if this code was inside remoting namespace

Done.

https://codereview.chromium.org/2049173003/diff/1/remoting/host/setup/start_h...
remoting/host/setup/start_host_main.cc:117: namespace remoting {
On 2016/06/08 21:47:10, Sergey Ulanov wrote:
> Move this before the anonymous namespace above, i.e.
> namespace remoting {
> 
> namesoace {
> ..
> }
> 
> int StartHostMain() {}
> 
> }

Done.

[joedow, 2016-06-09 04:17:59]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-06-09 04:18:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049173003/20001

[commit-bot: I haz the power, 2016-06-09 04:55:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 04:57:10]

Description was changed from

==========
Updating remoting_start_host to use remoting_core.dll

The remoting_start_host binary is much larger than other exes in the Windows
MSI (~5MB vs. 100KB).  This is because it links in a bunch of code we
already include in remoting_core.dll.

This change moves the shared code into remoting_core.dll and sets up the
remoting_start_host binary to use a shared library for other platforms if we
decide to do so later on.  It also updates the information that is stamped on
the windows exe so it reflects the name and purpose of the tool.

BUG=617182
==========

to

==========
Updating remoting_start_host to use remoting_core.dll

The remoting_start_host binary is much larger than other exes in the Windows
MSI (~5MB vs. 100KB).  This is because it links in a bunch of code we
already include in remoting_core.dll.

This change moves the shared code into remoting_core.dll and sets up the
remoting_start_host binary to use a shared library for other platforms if we
decide to do so later on.  It also updates the information that is stamped on
the windows exe so it reflects the name and purpose of the tool.

BUG=617182

Committed: https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8
Cr-Commit-Position: refs/heads/master@{#398787}
==========

[commit-bot: I haz the power, 2016-06-09 04:57:11]

Patchset 2 (id:??) landed as
https://crrev.com/0452cbe2412f985f46c12234c4bcfb6a2922b0e8
Cr-Commit-Position: refs/heads/master@{#398787}