Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2049143002: [memory-infra] Log reasons for memory dump failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index e4c48115dd2de2f8124dae0af83161e35d34a05d..7b155db3dff2099717a91383caaeb1f66d87ecab 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -1001,8 +1001,8 @@ void TracingControllerImpl::OnProcessMemoryDumpResponse(
pending_memory_dump_filters_.erase(it);
if (!success) {
++failed_memory_dump_count_;
- DLOG(WARNING) << "Global memory dump failed because of NACK from child "
- << trace_message_filter->peer_pid();
+ VLOG(1) << "Global memory dump failed because of NACK from child "
+ << trace_message_filter->peer_pid();
}
FinalizeGlobalMemoryDumpIfAllProcessesReplied();
}
@@ -1013,7 +1013,7 @@ void TracingControllerImpl::OnBrowserProcessMemoryDumpDone(uint64_t dump_guid,
--pending_memory_dump_ack_count_;
if (!success) {
++failed_memory_dump_count_;
- DLOG(WARNING) << "Global memory dump aborted on the current process";
+ VLOG(1) << "Global memory dump aborted on the current process";
}
FinalizeGlobalMemoryDumpIfAllProcessesReplied();
}

Powered by Google App Engine
This is Rietveld 408576698