Issue 204913006: Reland "Implement ES6 symbol registry and predefined symbols"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204913006: Reland "Implement ES6 symbol registry and predefined symbols" (Closed)

Created:
6 years, 9 months ago by rossberg

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Implement ES6 symbol registry and predefined symbols" Only change relative to original CL is the updated assertion condition at objects-inl.h:2119 R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20136

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -12 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/messages.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/symbol.js	View	2 chunks	+64 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/private.js	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/symbols.js	View	1 chunk	+38 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

LGTM to objects-inl.h:2119, didn't look at the rest.

6 years, 9 months ago (2014-03-20 14:22:32 UTC) #2

rossberg

6 years, 9 months ago (2014-03-20 16:13:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20136 (presubmit successful).