Issue 204913005: Remove HeapSnapshot._markInvisibleEdges

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204913005: Remove HeapSnapshot._markInvisibleEdges (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove HeapSnapshot._markInvisibleEdges The method is a noop as we first collect names of shortcut edges and then iterate through all non-shortcuts whose names are also in the collection. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169657

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -34 lines)			Patch
	M	Source/devtools/front_end/HeapSnapshot.js	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
	M	Source/devtools/front_end/JSHeapSnapshot.js	View	1	1 chunk	+0 lines, -27 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/204913005/20001

6 years, 9 months ago (2014-03-20 14:23:53 UTC) #6

Message was sent while issue was closed.

Change committed as 169657

Expand Messages | Collapse Messages