Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: tools/perf/benchmarks/battor.py

Issue 2049113002: [Android] Disable flaky BattOrCases telemetry_perf_unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 from telemetry.web_perf import timeline_based_measurement 6 from telemetry.web_perf import timeline_based_measurement
7 import page_sets 7 import page_sets
8 from telemetry import benchmark
8 9
9 10
10 class _BattOrBenchmark(perf_benchmark.PerfBenchmark): 11 class _BattOrBenchmark(perf_benchmark.PerfBenchmark):
11 12
12 def CreateTimelineBasedMeasurementOptions(self): 13 def CreateTimelineBasedMeasurementOptions(self):
13 options = timeline_based_measurement.Options() 14 options = timeline_based_measurement.Options()
14 options.config.enable_battor_trace = True 15 options.config.enable_battor_trace = True
15 # TODO(rnephew): Enable chrome trace when clock syncs work well with it. 16 # TODO(rnephew): Enable chrome trace when clock syncs work well with it.
16 options.config.enable_chrome_trace = False 17 options.config.enable_chrome_trace = False
17 options.SetTimelineBasedMetric('powerMetric') 18 options.SetTimelineBasedMetric('powerMetric')
18 return options 19 return options
19 20
20 @classmethod 21 @classmethod
21 def ShouldDisable(cls, possible_browser): 22 def ShouldDisable(cls, possible_browser):
22 # Only run if BattOr is detected. 23 # Only run if BattOr is detected.
23 if not possible_browser.platform.HasBattOrConnected(): 24 if not possible_browser.platform.HasBattOrConnected():
24 return True 25 return True
25 26
26 # Galaxy S5s have problems with running system health metrics. 27 # Galaxy S5s have problems with running system health metrics.
27 # http://crbug.com/600463 28 # http://crbug.com/600463
28 galaxy_s5_type_name = 'SM-G900H' 29 galaxy_s5_type_name = 'SM-G900H'
29 return possible_browser.platform.GetDeviceTypeName() == galaxy_s5_type_name 30 return possible_browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
30 31
31 @classmethod 32 @classmethod
32 def ShouldTearDownStateAfterEachStoryRun(cls): 33 def ShouldTearDownStateAfterEachStoryRun(cls):
33 return True 34 return True
34 35
35 36
37 @benchmark.Disabled('android') # crbug.com/618330
36 class BattOrPowerMobileSites(_BattOrBenchmark): 38 class BattOrPowerMobileSites(_BattOrBenchmark):
37 page_set = page_sets.power_cases.PowerCasesPageSet 39 page_set = page_sets.power_cases.PowerCasesPageSet
38 40
39 @classmethod 41 @classmethod
40 def Name(cls): 42 def Name(cls):
41 return 'BattOr.BattOrCases' 43 return 'BattOr.BattOrCases'
42 44
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698