chrome/browser/resources/gaia_auth_host/authenticator.js - Issue 2049103002: Fix SAML single-password scrapping authenticating with an empty password

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/gaia_auth_host/authenticator.js

Issue 2049103002: Fix SAML single-password scrapping authenticating with an empty password (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/gaia_auth_host/authenticator.js

diff --git a/chrome/browser/resources/gaia_auth_host/authenticator.js b/chrome/browser/resources/gaia_auth_host/authenticator.js

index 55a24f76def03b64ded67f09c3da9dd0b3ff65ca..f050b069c5333d5b13b15a32e18445a93de27661 100644

--- a/chrome/browser/resources/gaia_auth_host/authenticator.js

+++ b/chrome/browser/resources/gaia_auth_host/authenticator.js

@@ -662,7 +662,7 @@ cr.define('cr.login', function() {

if (this.samlHandler_.scrapedPasswordCount == 1) {

// If we scraped exactly one password, we complete the authentication

// right away.

- this.password = this.samlHandler_.firstScrapedPassword;

+ this.password_ = this.samlHandler_.firstScrapedPassword;

this.onAuthCompleted_();

return;

}

« no previous file with comments | « chrome/browser/chromeos/login/saml/saml_browsertest.cc ('k') | ui/login/display_manager.js » ('j') | no next file with comments »