Fix SAML single-password scrapping authenticating with an empty password

chrome/browser/resources/gaia_auth_host/authenticator.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="saml_handler.js">
 
 /**
  * @fileoverview An UI component to authenciate to Chrome. The component hosts
  * IdP web pages in a webview. A client who is interested in monitoring
  * authentication events should pass a listener object of type
@@ skipping 644 matching lines @@
       }
 
       // Fall through to finish the auth flow even if this.needPassword
       // is true. This is because the flag is used as an intention to get
       // password when it is available but not a mandatory requirement.
       console.warn('Authenticator: No password scraped for SAML.');
     } else if (this.needPassword) {
       if (this.samlHandler_.scrapedPasswordCount == 1) {
         // If we scraped exactly one password, we complete the authentication
         // right away.
-        this.password = this.samlHandler_.firstScrapedPassword;
+        this.password_ = this.samlHandler_.firstScrapedPassword;

[xiyuan, 2016/06/08 15:52:01]

Oops. Missed this on review. :p

[xiyuan, 2016/06/08 15:53:16]

I wonder whether we should extend SamlTest.ScrapedSingle to verify the scraped
password. 

[afakhry, 2016/06/08 16:34:28]

Done. Please take a look.

         this.onAuthCompleted_();
         return;
       }
 
       if (this.confirmPasswordCallback) {
         // Confirm scraped password. The flow follows in
         // verifyConfirmedPassword.
         this.confirmPasswordCallback(this.email_,
                                      this.samlHandler_.scrapedPasswordCount);
         return;
@@ skipping 187 matching lines @@
   Authenticator.AuthMode = AuthMode;
   Authenticator.SUPPORTED_PARAMS = SUPPORTED_PARAMS;
 
   return {
     // TODO(guohui, xiyuan): Rename GaiaAuthHost to Authenticator once the old
     // iframe-based flow is deprecated.
     GaiaAuthHost: Authenticator,
     Authenticator: Authenticator
   };
 });