Fix SAML single-password scrapping authenticating with an empty password

Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279, 617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449
Cr-Commit-Position: refs/heads/master@{#398624}

[afakhry, 2016-06-08 15:33:28]

Description was changed from

==========
Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
==========

to

==========
Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2016-06-08 15:35:56]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-06-08 15:35:56]

Xiyuan, please review. Thanks.

[xiyuan, 2016-06-08 15:52:01]

lgtm

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:665: this.password_ =
this.samlHandler_.firstScrapedPassword;
Oops. Missed this on review. :p

[xiyuan, 2016-06-08 15:53:16]

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:665: this.password_ =
this.samlHandler_.firstScrapedPassword;
On 2016/06/08 15:52:01, xiyuan wrote:
> Oops. Missed this on review. :p

I wonder whether we should extend SamlTest.ScrapedSingle to verify the scraped
password.

[afakhry, 2016-06-08 16:34:28]

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/2049103002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:665: this.password_ =
this.samlHandler_.firstScrapedPassword;
On 2016/06/08 15:53:16, xiyuan wrote:
> On 2016/06/08 15:52:01, xiyuan wrote:
> > Oops. Missed this on review. :p
> 
> I wonder whether we should extend SamlTest.ScrapedSingle to verify the scraped
> password. 

Done. Please take a look.

[xiyuan, 2016-06-08 16:40:23]

LGTM++

https://codereview.chromium.org/2049103002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/saml/saml_browsertest.cc (right):

https://codereview.chromium.org/2049103002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/saml/saml_browsertest.cc:520: ASSERT_EQ(message,
"\"fake_password\"");
nit: ASSERT_EQ not necessary since we would not be able to get out of the while
loop above otherwise.

[afakhry, 2016-06-08 16:47:08]

https://codereview.chromium.org/2049103002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/saml/saml_browsertest.cc (right):

https://codereview.chromium.org/2049103002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/saml/saml_browsertest.cc:520: ASSERT_EQ(message,
"\"fake_password\"");
On 2016/06/08 16:40:23, xiyuan wrote:
> nit: ASSERT_EQ not necessary since we would not be able to get out of the
while
> loop above otherwise.

Yes I was just being paranoid! :D
Done.

[afakhry, 2016-06-08 16:47:32]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-06-08 16:47:32]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2049103002/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2016-06-08 16:47:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049103002/40001

[commit-bot: I haz the power, 2016-06-08 18:25:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 18:27:37]

Description was changed from

==========
Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix SAML single-password scrapping authenticating with an empty password

Fix a JS syntax error that led to authentication with an empty password.
Also, remove setting enterpriseInfo in <offline-gaia> as it doesn't have
this property anymore.

BUG=618279,617962
TEST=manually with login/logout, lock/unlock.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449
Cr-Commit-Position: refs/heads/master@{#398624}
==========

[commit-bot: I haz the power, 2016-06-08 18:27:38]

Patchset 3 (id:??) landed as
https://crrev.com/ca6500c0f9f7dc2b8a8f865ca2ccf2df707b1449
Cr-Commit-Position: refs/heads/master@{#398624}