Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2049063004: Reland of "heap] Fix Sweeper::IsSweepingCompleted" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "heap] Fix Sweeper::IsSweepingCompleted" This reverts commit 0bccf3e66415fc6cee9528bf8777e0b30c31c435. R=ulan@chromium.org Committed: https://crrev.com/f4e4fd71059dd7366eed2df1fa84968dbb0b14ce Cr-Commit-Position: refs/heads/master@{#36851}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/heap/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
MarkCompactCollector::Sweeper::IsSweepingCompleted can be called from compaction tasks, requiring atomic handling for the counter.
4 years, 6 months ago (2016-06-09 10:45:02 UTC) #1
ulan
lgtm
4 years, 6 months ago (2016-06-09 10:48:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049063004/20001
4 years, 6 months ago (2016-06-09 10:49:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 11:19:40 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 11:22:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4e4fd71059dd7366eed2df1fa84968dbb0b14ce
Cr-Commit-Position: refs/heads/master@{#36851}

Powered by Google App Engine
This is Rietveld 408576698