Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2049053003: Remove IPC::ParamTraits for ui::Event. (Closed)

Created:
4 years, 6 months ago by Hadi
Modified:
4 years, 6 months ago
Reviewers:
sadrul, sky, Mark Dittmer
CC:
chromium-reviews, rjkroege, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IPC::ParamTraits for ui::Event. We decided to use struct traits for ui::Event and don't need the param traits anymore. This CL reverts the changes we don't need anymore in the following CLs: * https://codereview.chromium.org/1695783002/ * https://codereview.chromium.org/1800633002/ BUG=584687 Committed: https://crrev.com/050ea6592f80eec952c40f8c2e3b40d281bc7f24 Cr-Commit-Position: refs/heads/master@{#398653}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1078 lines) Patch
M components/mus/common/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D components/mus/common/event_param_traits.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/mus/common/event_param_traits.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D components/mus/common/event_param_traits_macros.h View 1 chunk +0 lines, -112 lines 0 comments Download
D components/mus/common/event_param_traits_unittest.cc View 1 chunk +0 lines, -496 lines 0 comments Download
M ui/events/event.h View 12 chunks +0 lines, -67 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/gesture_event_details.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/events/keycodes/dom/dom_key.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Hadi
PTAL.
4 years, 6 months ago (2016-06-08 15:40:43 UTC) #3
Mark Dittmer
One nit related to bot failure. Otherwise, lgtm. https://codereview.chromium.org/2049053003/diff/20001/components/mus/DEPS File components/mus/DEPS (left): https://codereview.chromium.org/2049053003/diff/20001/components/mus/DEPS#oldcode3 components/mus/DEPS:3: "+ipc", ...
4 years, 6 months ago (2016-06-08 16:39:49 UTC) #4
sadrul
lgtm++
4 years, 6 months ago (2016-06-08 16:58:39 UTC) #5
Hadi
https://codereview.chromium.org/2049053003/diff/20001/components/mus/DEPS File components/mus/DEPS (left): https://codereview.chromium.org/2049053003/diff/20001/components/mus/DEPS#oldcode3 components/mus/DEPS:3: "+ipc", On 2016/06/08 16:39:49, Mark Dittmer wrote: > Looks ...
4 years, 6 months ago (2016-06-08 17:37:45 UTC) #6
sky
mus LGTM
4 years, 6 months ago (2016-06-08 20:10:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049053003/40001
4 years, 6 months ago (2016-06-08 20:11:18 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 20:17:16 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:18:52 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/050ea6592f80eec952c40f8c2e3b40d281bc7f24
Cr-Commit-Position: refs/heads/master@{#398653}

Powered by Google App Engine
This is Rietveld 408576698