Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2049003004: [Mac/GN] dSYM output always goes in root_out_dir, so specify it in linker outputs. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] dSYM output always goes in root_out_dir, so specify it in linker outputs. This was causing overbuild for targets that override the output directory, since the linker_driver.py is configured to place dSYMs in root_out_dir, but the linker output was listed in the target_out_dir. BUG=330301, 431177 R=brettw@chromium.org Committed: https://crrev.com/0dda1538d9a8e10e8ad5288b3c2a71cd2437b643 Cr-Commit-Position: refs/heads/master@{#398739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/toolchain/mac/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 6 months ago (2016-06-08 20:15:32 UTC) #1
brettw
lgtm
4 years, 6 months ago (2016-06-08 22:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049003004/1
4 years, 6 months ago (2016-06-08 22:52:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 23:59:18 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 00:01:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dda1538d9a8e10e8ad5288b3c2a71cd2437b643
Cr-Commit-Position: refs/heads/master@{#398739}

Powered by Google App Engine
This is Rietveld 408576698