Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2049003003: Add some consts and remove more casts in core/ (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add some consts and remove more casts in core/ Committed: https://pdfium.googlesource.com/pdfium/+/c1835615f386d8e6e30df89b6517ebf605335a0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -97 lines) Patch
M core/fpdfdoc/ctypeset.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M core/fpdfdoc/doc_form.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfdoc/doc_formfield.cpp View 17 chunks +30 lines, -29 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 4 chunks +32 lines, -53 lines 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, pls review.
4 years, 6 months ago (2016-06-08 20:11:39 UTC) #2
dsinclair
lgtm
4 years, 6 months ago (2016-06-08 20:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049003003/1
4 years, 6 months ago (2016-06-08 20:15:53 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:30:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c1835615f386d8e6e30df89b6517ebf60533...

Powered by Google App Engine
This is Rietveld 408576698