third_party/WebKit/Source/modules/webusb/USB.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp ('k') | third_party/WebKit/Source/modules/webusb/USBDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webusb/USB.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USB.cpp b/third_party/WebKit/Source/modules/webusb/USB.cpp

index 9c6481cd0b247de01d57efc8244c6a1fb37b9306..d1461fb9d306db3d38b1c04de62915d541984c2c 100644

--- a/third_party/WebKit/Source/modules/webusb/USB.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USB.cpp

@@ -88,7 +88,7 @@ ScriptPromise USB::getDevices(ScriptState* scriptState)

resolver->reject(DOMException::create(SecurityError, errorMessage));

} else {

m_deviceManagerRequests.add(resolver);

- m_deviceManager->GetDevices(nullptr, createBaseCallback(bind(&USB::onGetDevices, this, resolver)));

+ m_deviceManager->GetDevices(nullptr, createBaseCallback(bind(&USB::onGetDevices, wrapPersistent(this), wrapPersistent(resolver))));

}

return promise;

@@ -122,7 +122,7 @@ ScriptPromise USB::requestDevice(ScriptState* scriptState, const USBDeviceReques

filters.append(convertDeviceFilter(filter));

}

m_chooserServiceRequests.add(resolver);

- m_chooserService->GetPermission(std::move(filters), createBaseCallback(bind(&USB::onGetPermission, this, resolver)));

+ m_chooserService->GetPermission(std::move(filters), createBaseCallback(bind(&USB::onGetPermission, wrapPersistent(this), wrapPersistent(resolver))));

}

return promise;

}