third_party/WebKit/Source/modules/nfc/NFC.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/nfc/NFC.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/nfc/NFC.cpp

diff --git a/third_party/WebKit/Source/modules/nfc/NFC.cpp b/third_party/WebKit/Source/modules/nfc/NFC.cpp

index 0df7dd4013f0942d0a5bdbb693e55806396917e3..bca190acdaa2fec62a0b332fe9572cffa4de49d8 100644

--- a/third_party/WebKit/Source/modules/nfc/NFC.cpp

+++ b/third_party/WebKit/Source/modules/nfc/NFC.cpp

@@ -495,7 +495,7 @@ ScriptPromise NFC::push(ScriptState* scriptState, const NFCPushMessage& pushMess

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

m_requests.add(resolver);

- auto callback = createBaseCallback(bind(&NFC::OnRequestCompleted, this, resolver));

+ auto callback = createBaseCallback(bind(&NFC::OnRequestCompleted, wrapPersistent(this), wrapPersistent(resolver)));

m_nfc->Push(std::move(message), nfc::NFCPushOptions::From(options), callback);

return resolver->promise();

@@ -512,7 +512,7 @@ ScriptPromise NFC::cancelPush(ScriptState* scriptState, const String& target)

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

m_requests.add(resolver);

- auto callback = createBaseCallback(bind(&NFC::OnRequestCompleted, this, resolver));

+ auto callback = createBaseCallback(bind(&NFC::OnRequestCompleted, wrapPersistent(this), wrapPersistent(resolver)));

m_nfc->CancelPush(mojo::toNFCPushTarget(target), callback);

return resolver->promise();