third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp ('k') | third_party/WebKit/Source/core/html/forms/SearchInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp

index 423c670d15256365477b6fa4417b0ec205732354..8292602ae93763ec6fcc0a3c591fb939862c9ad2 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp

@@ -78,8 +78,7 @@ public:

protected:

void scheduleInitiatePngEncoding() override

{

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE,

- bind(&MockCanvasAsyncBlobCreatorWithoutCompletePng::initiatePngEncoding, this, std::numeric_limits<double>::max()));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, bind(&MockCanvasAsyncBlobCreatorWithoutCompletePng::initiatePngEncoding, wrapPersistent(this), std::numeric_limits<double>::max()));

}

void idleEncodeRowsPng(double deadlineSeconds) override

@@ -118,8 +117,7 @@ public:

protected:

void scheduleInitiateJpegEncoding(const double& quality) override

{

- Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE,

- bind(&MockCanvasAsyncBlobCreatorWithoutCompleteJpeg::initiateJpegEncoding, this, quality, std::numeric_limits<double>::max()));

+ Platform::current()->mainThread()->getWebTaskRunner()->postTask(BLINK_FROM_HERE, bind(&MockCanvasAsyncBlobCreatorWithoutCompleteJpeg::initiateJpegEncoding, wrapPersistent(this), quality, std::numeric_limits<double>::max()));

}

void idleEncodeRowsJpeg(double deadlineSeconds) override