third_party/WebKit/Source/modules/vr/VRController.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRController.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/wrapCrossThreadPersistent/wrapPersistent/ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vibration/VibrationController.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp » ('j') | third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRController.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRController.cpp b/third_party/WebKit/Source/modules/vr/VRController.cpp

index b3bce61997bc4105bd15648a9063121f75f0ef60..007409b9aa62cbddacb74d7516019389d867edd6 100644

--- a/third_party/WebKit/Source/modules/vr/VRController.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRController.cpp

@@ -47,7 +47,7 @@ void VRController::getDisplays(std::unique_ptr<VRGetDevicesCallback> callback)

}

m_pendingGetDevicesCallbacks.append(std::move(callback));

- m_service->GetDisplays(createBaseCallback(bind<mojo::WTFArray<device::blink::VRDisplayPtr>>(&VRController::onGetDisplays, this)));

+ m_service->GetDisplays(createBaseCallback(bind<mojo::WTFArray<device::blink::VRDisplayPtr>>(&VRController::onGetDisplays, wrapPersistent(this))));

}

device::blink::VRPosePtr VRController::getPose(unsigned index)