third_party/WebKit/Source/core/fileapi/FileReader.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReader.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase. split RejectedPromise case to another CL. use wrapPersistent in HTMLSlotElement. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp ('K') | « third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/FileReader.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/FileReader.cpp b/third_party/WebKit/Source/core/fileapi/FileReader.cpp

index 8824f8079a07fd361152da5f5ab7b66cd48f89f3..0526cb1bf91515729b12e21ccde3e8409dc1f5bf 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReader.cpp

+++ b/third_party/WebKit/Source/core/fileapi/FileReader.cpp

@@ -335,7 +335,7 @@ void FileReader::abort()

// Schedule to have the abort done later since abort() might be called from the event handler and we do not want the resource loading code to be in the stack.

getExecutionContext()->postTask(

- BLINK_FROM_HERE, createSameThreadTask(&delayedAbort, this));

+ BLINK_FROM_HERE, createSameThreadTask(&delayedAbort, wrapCrossThreadPersistent(this)));

haraken 2016/06/22 06:27:43 Ditto.

tzik 2016/06/22 08:26:04 Done.

}

void FileReader::doAbort()