third_party/WebKit/Source/core/dom/ExecutionContext.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase. split RejectedPromise case to another CL. use wrapPersistent in HTMLSlotElement. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp » ('j') | third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ExecutionContext.cpp

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

index 4a49825c094cff40829c9387b9d6ce4a44e15f07..0312ad3f1c3711df82b2a105f4cfda08f2478531 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.cpp

@@ -94,7 +94,7 @@ void ExecutionContext::postSuspendableTask(std::unique_ptr<SuspendableTask> task

{

m_suspendedTasks.append(std::move(task));

if (!m_activeDOMObjectsAreSuspended)

- postTask(BLINK_FROM_HERE, createSameThreadTask(&ExecutionContext::runSuspendableTasks, this));

+ postTask(BLINK_FROM_HERE, createSameThreadTask(&ExecutionContext::runSuspendableTasks, wrapCrossThreadPersistent(this)));

haraken 2016/06/22 06:27:43 It looks strange that you use a CrossThreadPersist

tzik 2016/06/22 08:26:04 Done.

}

void ExecutionContext::notifyContextDestroyed()

@@ -120,7 +120,7 @@ void ExecutionContext::resumeScheduledTasks()

if (m_isRunSuspendableTasksScheduled)

return;

m_isRunSuspendableTasksScheduled = true;

- postTask(BLINK_FROM_HERE, createSameThreadTask(&ExecutionContext::runSuspendableTasks, this));

+ postTask(BLINK_FROM_HERE, createSameThreadTask(&ExecutionContext::runSuspendableTasks, wrapCrossThreadPersistent(this)));

haraken 2016/06/22 06:27:43 Ditto.

tzik 2016/06/22 08:26:04 Done.

}

void ExecutionContext::suspendActiveDOMObjectIfNeeded(ActiveDOMObject* object)