third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert "unretained" part and "disallow pointers" part Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLSlotElement.cpp ('K') | « third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

index fd96d6119b39cdd45bc2dee7251e17f03037ced3..9355e4e2d4404324e08051985be466a546b4f807 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

@@ -112,7 +112,7 @@ bool throwExceptionIfSignalingStateClosed(RTCPeerConnection::SignalingState stat

void asyncCallErrorCallback(RTCPeerConnectionErrorCallback* errorCallback, DOMException* exception)

{

DCHECK(errorCallback);

- Microtask::enqueueMicrotask(bind(&RTCPeerConnectionErrorCallback::handleEvent, errorCallback, exception));

+ Microtask::enqueueMicrotask(bind(&RTCPeerConnectionErrorCallback::handleEvent, wrapCrossThreadPersistent(errorCallback), wrapCrossThreadPersistent(exception)));

}

bool callErrorCallbackIfSignalingStateClosed(RTCPeerConnection::SignalingState state, RTCPeerConnectionErrorCallback* errorCallback)

@@ -1181,7 +1181,7 @@ void RTCPeerConnection::changeIceConnectionState(ICEConnectionState iceConnectio

{

if (m_iceConnectionState != ICEConnectionStateClosed) {

scheduleDispatchEvent(Event::create(EventTypeNames::iceconnectionstatechange),

- WTF::bind(&RTCPeerConnection::setIceConnectionState, this, iceConnectionState));

+ WTF::bind(&RTCPeerConnection::setIceConnectionState, wrapCrossThreadPersistent(this), iceConnectionState));

}