third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert "unretained" part and "disallow pointers" part Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLSlotElement.cpp ('K') | « third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp ('k') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index e6e48acb49603b7a781636bea81e181b75ce3604..b5ce7085d1f609d992e01504407cdff4343e29a6 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -428,7 +428,7 @@ void Geolocation::requestPermission()

m_permissionService->RequestPermission(

mojom::blink::PermissionName::GEOLOCATION,

getExecutionContext()->getSecurityOrigin()->toString(),

- createBaseCallback(bind<mojom::blink::PermissionStatus>(&Geolocation::onGeolocationPermissionUpdated, this)));

+ createBaseCallback(bind<mojom::blink::PermissionStatus>(&Geolocation::onGeolocationPermissionUpdated, wrapCrossThreadPersistent(this))));

}

void Geolocation::makeSuccessCallbacks()

@@ -501,7 +501,7 @@ void Geolocation::updateGeolocationServiceConnection()

void Geolocation::queryNextPosition()

{

- m_geolocationService->QueryNextPosition(createBaseCallback(bind<mojom::blink::GeopositionPtr>(&Geolocation::onPositionUpdated, this)));

+ m_geolocationService->QueryNextPosition(createBaseCallback(bind<mojom::blink::GeopositionPtr>(&Geolocation::onPositionUpdated, wrapCrossThreadPersistent(this))));

}

void Geolocation::onPositionUpdated(mojom::blink::GeopositionPtr position)