third_party/WebKit/Source/core/html/HTMLSlotElement.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert "unretained" part and "disallow pointers" part Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

index 02e9279d0792cbb813b7d80195ed553274ce64ec..d4256cc156494fb2f776d80ffe87e5e904d5a185 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

@@ -294,7 +294,7 @@ void HTMLSlotElement::updateDistributedNodesWithFallback()

void HTMLSlotElement::enqueueSlotChangeEvent()

{

if (!m_slotchangeEventEnqueued) {

- Microtask::enqueueMicrotask(WTF::bind(&HTMLSlotElement::dispatchSlotChangeEvent, Persistent<HTMLSlotElement>(this)));

+ Microtask::enqueueMicrotask(WTF::bind(&HTMLSlotElement::dispatchSlotChangeEvent, wrapCrossThreadPersistent(this)));

hiroshige 2016/06/15 12:12:39 Shouldn't this be |wrapPersistent(this)| to keep t

tzik 2016/06/21 09:09:04 Done.

m_slotchangeEventEnqueued = true;

}