third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2049003002: Wrap GCed raw pointer parameters of WTF::bind with Persistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert "unretained" part and "disallow pointers" part Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/core/fileapi/FileReader.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 130fa525436b6c9a99074fab4f406eab4484d746..df5cfe0f3bf72a5b8fcf37d03fb4b99eff6c9955 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -408,7 +408,7 @@ void LocalDOMWindow::dispatchWindowLoadEvent()

// workaround to avoid Editing code crashes. We should always dispatch

// 'load' event asynchronously. crbug.com/569511.

if (ScopedEventQueue::instance()->shouldQueueEvents() && m_document) {

- m_document->postTask(BLINK_FROM_HERE, createSameThreadTask(&LocalDOMWindow::dispatchLoadEvent, this));

+ m_document->postTask(BLINK_FROM_HERE, createSameThreadTask(&LocalDOMWindow::dispatchLoadEvent, wrapCrossThreadPersistent(this)));

return;

}

dispatchLoadEvent();