Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2048953002: Revert of Simplify import-w3c-tests: support exactly one argument. (Closed)

Created:
4 years, 6 months ago by kinuko
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, qyearsley, ojan
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina, dcampb, raikiri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify import-w3c-tests: support exactly one argument. (patchset #7 id:120001 of https://codereview.chromium.org/1998413002/ ) Reason for revert: This seems to have caused consecutive webkit python test failures. Probably there should be an easy fix but let me revert this for now. { "failures": [ "webkitpy/w3c/test_importer_unittest/TestImporterTest/test_does_not_import_reftest" ], "valid": true } Original issue's description: > Simplify import-w3c-tests: support exactly one argument. > > Specifically, take the source repo path (top of repo) as the required argument, and don't support importing single subdirectories. > > Reason: > > 1. Using the current directory as the top of repo may be a bit confusing. > > 2. In the future, I believe we want some kind of auto-updater that updates everything at once and we won't need to support importing individual directories. At present, I believe the only thing that uses import-w3c-tests is update-w3c-deps which, which doesn't currently have an option for updating just one subdirectory. > > Committed: https://crrev.com/868f94e75ad4b86b2a8a6c15b694cde508af91ee > Cr-Commit-Position: refs/heads/master@{#398437} TBR=dpranke@chromium.org,ojan@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c34176442a2f64bfec4960a72a92d93865863ee9 Cr-Commit-Position: refs/heads/master@{#398473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 9 chunks +35 lines, -20 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kinuko
Created Revert of Simplify import-w3c-tests: support exactly one argument.
4 years, 6 months ago (2016-06-08 03:48:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048953002/1
4 years, 6 months ago (2016-06-08 03:48:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 03:49:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c34176442a2f64bfec4960a72a92d93865863ee9 Cr-Commit-Position: refs/heads/master@{#398473}
4 years, 6 months ago (2016-06-08 03:51:40 UTC) #7
qyearsley
4 years, 6 months ago (2016-06-08 16:02:28 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2049803002/ by qyearsley@chromium.org.

The reason for reverting is: Making a reland CL to try to fix the unit test
failure..

Powered by Google App Engine
This is Rietveld 408576698