Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2048943002: Fix an assertion failure in InputType::applyStep() (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an assertion failure in InputType::applyStep() If stepBase is extremely larger than step or maximum, the old code produced alignedMaximum larger than maximum(). This CL fixes it. - The core logic is moved to StepRange class to improve testability - Move the stream printer for Decimal because it is used in DCHECK_LE(). BUG=617809 Committed: https://crrev.com/ee4915d796448f4024de2c943a52b007021ead03 Cr-Commit-Position: refs/heads/master@{#399563}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRangeTest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Decimal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Decimal.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/DecimalTest.cpp View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
tkent
Keishi, would you review this please? No hurry.
4 years, 6 months ago (2016-06-08 05:21:26 UTC) #5
keishi
LGTM
4 years, 6 months ago (2016-06-13 14:58:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048943002/20001
4 years, 6 months ago (2016-06-13 16:33:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/162290)
4 years, 6 months ago (2016-06-13 17:56:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048943002/20001
4 years, 6 months ago (2016-06-13 21:23:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-13 22:00:04 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 22:00:06 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:01:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee4915d796448f4024de2c943a52b007021ead03
Cr-Commit-Position: refs/heads/master@{#399563}

Powered by Google App Engine
This is Rietveld 408576698