Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2048933005: bluetooth: Improve NOT_ALLOWED_TO_ACCESS_SERVICE error message (Closed)

Created:
4 years, 6 months ago by François Beaufort
Modified:
4 years, 6 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Improve NOT_ALLOWED_TO_ACCESS_SERVICE error message Committed: https://crrev.com/b325b3a86985fc17904c82f712acf41b6a96defb Cr-Commit-Position: refs/heads/master@{#399984}

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/delayed-discovery-no-permission-absent-service.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/delayed-discovery-no-permission-present-service.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/no-permission-absent-service.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/no-permission-present-service.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blacklisted-services-with-uuid.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-absent-service-with-uuid.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service-with-uuid.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission-absent-service-with-uuid.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission-present-service-with-uuid.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice/blacklisted-service-in-optionalServices.html View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048933005/20001
4 years, 6 months ago (2016-06-15 11:50:41 UTC) #2
François Beaufort
Hello Gio, As discussed in web-bluetooth-chromium hangouts, here's a CL that attempts to improve message ...
4 years, 6 months ago (2016-06-15 13:13:29 UTC) #3
François Beaufort
Hello Gio, As discussed in web-bluetooth-chromium hangouts, here's a CL that attempts to improve message ...
4 years, 6 months ago (2016-06-15 13:14:04 UTC) #5
ortuno
lgtm
4 years, 6 months ago (2016-06-15 15:46:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 16:12:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048933005/20001
4 years, 6 months ago (2016-06-15 19:00:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 19:07:55 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 19:08:04 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 19:10:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b325b3a86985fc17904c82f712acf41b6a96defb
Cr-Commit-Position: refs/heads/master@{#399984}

Powered by Google App Engine
This is Rietveld 408576698