Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5265)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2048923002: Fixes for turning on offliner request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put const& back on LoadPageCallback param Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 75376ac6e6723163408834b51cb15afc493f229d..ad74af1458133bf5b9f7308ba9abc35b5868fcb1 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -73,10 +73,10 @@ class PrerenderingOffliner : public Offliner {
OfflinePageModel* offline_page_model_;
// Lazily created.
std::unique_ptr<PrerenderingLoader> loader_;
- // Tracks pending request, if any. Not owned.
+ // Tracks pending request, if any. Owned copy.
// May be used to ensure a callback applies to the pending request (e.g., in
// case we receive a save page callback for an old, canceled request).
- SavePageRequest const* pending_request_;
+ std::unique_ptr<SavePageRequest> pending_request_;
base::WeakPtrFactory<PrerenderingOffliner> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(PrerenderingOffliner);

Powered by Google App Engine
This is Rietveld 408576698