Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: chrome/browser/android/offline_pages/prerender_adapter.cc

Issue 2048923002: Fixes for turning on offliner request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put const& back on LoadPageCallback param Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_offliner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerender_adapter.h" 5 #include "chrome/browser/android/offline_pages/prerender_adapter.h"
6 6
7 #include "chrome/browser/prerender/prerender_manager.h" 7 #include "chrome/browser/prerender/prerender_manager.h"
8 #include "chrome/browser/prerender/prerender_manager_factory.h" 8 #include "chrome/browser/prerender/prerender_manager_factory.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "content/public/browser/browser_context.h" 10 #include "content/public/browser/browser_context.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 DCHECK(active_handle_->contents()); 67 DCHECK(active_handle_->contents());
68 return active_handle_->contents()->final_status(); 68 return active_handle_->contents()->final_status();
69 } 69 }
70 70
71 bool PrerenderAdapter::IsActive() const { 71 bool PrerenderAdapter::IsActive() const {
72 return active_handle_.get(); 72 return active_handle_.get();
73 } 73 }
74 74
75 void PrerenderAdapter::DestroyActive() { 75 void PrerenderAdapter::DestroyActive() {
76 DCHECK(IsActive()); 76 DCHECK(IsActive());
77 active_handle_->OnCancel(); 77 // Clear active handle and call OnCancel from local variable to avoid
78 active_handle_.reset(nullptr); 78 // immediate Observer OnPrerenderStop() call from thinking still active.
79 prerender::PrerenderHandle* handle_to_destroy = active_handle_.release();
80 handle_to_destroy->OnCancel();
81 delete handle_to_destroy;
79 } 82 }
80 83
81 void PrerenderAdapter::OnPrerenderStart(prerender::PrerenderHandle* handle) { 84 void PrerenderAdapter::OnPrerenderStart(prerender::PrerenderHandle* handle) {
82 DCHECK(active_handle_.get() == handle); 85 DCHECK(active_handle_.get() == handle);
83 observer_->OnPrerenderStart(); 86 observer_->OnPrerenderStart();
84 } 87 }
85 88
86 void PrerenderAdapter::OnPrerenderStopLoading( 89 void PrerenderAdapter::OnPrerenderStopLoading(
87 prerender::PrerenderHandle* handle) { 90 prerender::PrerenderHandle* handle) {
88 DCHECK(active_handle_.get() == handle); 91 DCHECK(active_handle_.get() == handle);
89 observer_->OnPrerenderDomContentLoaded(); 92 observer_->OnPrerenderStopLoading();
90 } 93 }
91 94
92 void PrerenderAdapter::OnPrerenderDomContentLoaded( 95 void PrerenderAdapter::OnPrerenderDomContentLoaded(
93 prerender::PrerenderHandle* handle) { 96 prerender::PrerenderHandle* handle) {
94 DCHECK(active_handle_.get() == handle); 97 DCHECK(active_handle_.get() == handle);
95 observer_->OnPrerenderDomContentLoaded(); 98 observer_->OnPrerenderDomContentLoaded();
96 } 99 }
97 100
98 void PrerenderAdapter::OnPrerenderStop(prerender::PrerenderHandle* handle) { 101 void PrerenderAdapter::OnPrerenderStop(prerender::PrerenderHandle* handle) {
99 DCHECK(active_handle_.get() == handle); 102 if (IsActive()) {
100 observer_->OnPrerenderStop(); 103 DCHECK(active_handle_.get() == handle);
104 observer_->OnPrerenderStop();
105 }
101 } 106 }
102 107
103 } // namespace offline_pages 108 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_offliner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698