IntersectionObserver: Warn when target is not a descendant of root.

IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org

Committed: https://crrev.com/33e0e1347fd2172236dc961805e956fecc159b80
Cr-Commit-Position: refs/heads/master@{#398794}

[szager1, 2016-06-08 17:15:33]

Description was changed from

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org
==========

to

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org
==========

[szager1, 2016-06-08 17:15:33]

szager@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-06-08 17:27:52]

On 2016/06/08 at 17:15:37, szager wrote:
> 

The code here looks clean and makes sense. Is this behavior spec'd somewhere
though? The error message is very specific about being on the "containing block"
chain--is that required?

[szager1, 2016-06-08 17:55:25]

On 2016/06/08 17:27:52, pdr. wrote:
> On 2016/06/08 at 17:15:37, szager wrote:
> > 
> 
> The code here looks clean and makes sense. Is this behavior spec'd somewhere
> though? The error message is very specific about being on the "containing
block"
> chain--is that required?

It's not spec'd; warnings are not typically spec'd, but this one seems useful.

The containing block chain check is more useful, but at the time this code runs,
it's possible that style and layout are dirty, so checking for containing block
would probably cause spurious errors.  The DOM check will not catch all
problems, but it could be a useful signal to developers by catching a lot of
them.

[szager1, 2016-06-08 17:55:50]

On 2016/06/08 17:55:25, szager1 wrote:
> On 2016/06/08 17:27:52, pdr. wrote:
> > On 2016/06/08 at 17:15:37, szager wrote:
> > > 
> > 
> > The code here looks clean and makes sense. Is this behavior spec'd somewhere
> > though? The error message is very specific about being on the "containing
> block"
> > chain--is that required?
> 
> It's not spec'd; warnings are not typically spec'd, but this one seems useful.
> 
> The containing block chain check is more useful, but at the time this code
runs,
> it's possible that style and layout are dirty, so checking for containing
block
> would probably cause spurious errors.  The DOM check will not catch all
> problems, but it could be a useful signal to developers by catching a lot of
> them.

Oh, the containing block message is out of date; I will fix it.

[pdr., 2016-06-08 18:01:22]

On 2016/06/08 at 17:55:50, szager wrote:
> On 2016/06/08 17:55:25, szager1 wrote:
> > On 2016/06/08 17:27:52, pdr. wrote:
> > > On 2016/06/08 at 17:15:37, szager wrote:
> > > > 
> > > 
> > > The code here looks clean and makes sense. Is this behavior spec'd
somewhere
> > > though? The error message is very specific about being on the "containing
> > block"
> > > chain--is that required?
> > 
> > It's not spec'd; warnings are not typically spec'd, but this one seems
useful.
> > 
> > The containing block chain check is more useful, but at the time this code
runs,
> > it's possible that style and layout are dirty, so checking for containing
block
> > would probably cause spurious errors.  The DOM check will not catch all
> > problems, but it could be a useful signal to developers by catching a lot of
> > them.
> 
> Oh, the containing block message is out of date; I will fix it.

LGTM with test updated to say "IntersectionObserver.observe(target): target
element is not a descendant of root."

[szager1, 2016-06-08 18:05:19]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-06-08 18:05:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048853002/20001

[commit-bot: I haz the power, 2016-06-08 19:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 19:33:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[szager1, 2016-06-08 20:22:36]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-06-08 20:22:36]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2048853002/#ps40001
(title: "fix test expectation")

[commit-bot: I haz the power, 2016-06-08 20:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048853002/40001

[commit-bot: I haz the power, 2016-06-09 01:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 01:12:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[szager1, 2016-06-09 01:29:04]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-06-09 01:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048853002/40001

[commit-bot: I haz the power, 2016-06-09 05:46:47]

Description was changed from

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org
==========

to

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org
==========

[commit-bot: I haz the power, 2016-06-09 05:46:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 05:48:02]

Description was changed from

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org
==========

to

==========
IntersectionObserver: Warn when target is not a descendant of root.

BUG=617393
R=eae@chromium.org

Committed: https://crrev.com/33e0e1347fd2172236dc961805e956fecc159b80
Cr-Commit-Position: refs/heads/master@{#398794}
==========

[commit-bot: I haz the power, 2016-06-09 05:48:03]

Patchset 3 (id:??) landed as
https://crrev.com/33e0e1347fd2172236dc961805e956fecc159b80
Cr-Commit-Position: refs/heads/master@{#398794}

[eae, 2016-06-09 05:59:53]

LGTM post-facto