Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204883002: get extra_src value from factory_properties (Closed)

Created:
6 years, 9 months ago by zty
Modified:
6 years, 9 months ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

get extra_src value from factory_properties BUG=301552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/buildbot/bb_host_steps.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
zty
This change is needed to propagate extra_src.
6 years, 9 months ago (2014-03-19 17:53:06 UTC) #1
navabi
lgtm
6 years, 9 months ago (2014-03-19 19:16:29 UTC) #2
zty
The CQ bit was checked by zty@chromium.org
6 years, 9 months ago (2014-03-19 19:17:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/204883002/1
6 years, 9 months ago (2014-03-19 19:19:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 19:23:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 19:23:30 UTC) #6
navabi1
lgtm
6 years, 9 months ago (2014-03-19 19:54:50 UTC) #7
zty
The CQ bit was checked by zty@chromium.org
6 years, 9 months ago (2014-03-19 19:55:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/204883002/1
6 years, 9 months ago (2014-03-19 19:56:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:01:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 20:01:47 UTC) #11
zty
The CQ bit was checked by zty@chromium.org
6 years, 9 months ago (2014-03-19 20:38:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/204883002/1
6 years, 9 months ago (2014-03-19 20:38:59 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 23:50:27 UTC) #14
Message was sent while issue was closed. 
Change committed as 258159

Powered by Google App Engine
This is Rietveld 408576698