Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Issue 2048823004: PaymentRequest.abort() should return a promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
index f81c712eca678bd54550e1f80fa510243495469b..199cd6bf2b61006891dd62e76ddddb6e1801cbac 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
@@ -83,11 +83,20 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeA
}
});
assertWaitForPageScaleFactorMatch(1);
+ clickNodeAndWait("buy", helper);
+ mUI = helper.getTarget();
+ }
+ protected void clickNodeAndWait(String nodeId, CallbackHelper helper)
+ throws InterruptedException, ExecutionException, TimeoutException {
int callCount = helper.getCallCount();
- DOMUtils.clickNode(this, mViewCoreRef.get(), "buy");
+ clickNode(nodeId);
helper.waitForCallback(callCount);
- mUI = helper.getTarget();
+ }
+
+ protected void clickNode(String nodeId) throws InterruptedException, ExecutionException,
+ TimeoutException {
gone 2016/06/09 15:49:28 nit: indentation is wonky
please use gerrit instead 2016/06/09 22:36:14 Done.
+ DOMUtils.clickNode(this, mViewCoreRef.get(), nodeId);
}
protected void clickAndWait(final int resourceId, CallbackHelper helper)

Powered by Google App Engine
This is Rietveld 408576698