third_party/WebKit/Source/modules/payments/PaymentRequest.idl - Issue 2048823004: PaymentRequest.abort() should return a promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.idl

Issue 2048823004: PaymentRequest.abort() should return a promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved V8TestingScope refactoring into a different patch Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.idl

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.idl b/third_party/WebKit/Source/modules/payments/PaymentRequest.idl

index eee56b6eadfa786360033fbceeeae9caff176c08..5494a3b403c1eefe6bc906e9275bf2b27cb80c52 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.idl

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.idl

@@ -14,7 +14,7 @@

DependentLifetime,

] interface PaymentRequest : EventTarget {

[CallWith=ScriptState] Promise<PaymentResponse> show();

- [RaisesException] void abort();

+ [CallWith=ScriptState] Promise<void> abort();

[ImplementedAs=getShippingAddress] readonly attribute PaymentAddress? shippingAddress;

readonly attribute DOMString? shippingOption;