PaymentRequest.abort() should return a promise.

third_party/WebKit/Source/modules/payments/MockFunction.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MockFunction_h
+#define MockFunction_h
+
+#include "bindings/core/v8/ScriptFunction.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace blink {
+
+class ScriptState;
+class ScriptValue;
+
+class MockFunction : public ScriptFunction {

[Marijn Kruisselbrink, 2016/06/08 22:44:12]

I'm a bit uncomfortable with having something named as generic as
blink::MockFunction in such a non-generic location. Couldn't this be part of
PaymentRequestTestBase somehow to not pollute the global blink:: namespace with
generic names?

[haraken, 2016/06/09 01:57:58]

It would be better to move this class to V8BindingForTesting.h so that others
can use it.

[please use gerrit instead, 2016/06/09 22:36:14]

Actually, turns out this implementation of MockFunction does not fail the test
if the expectations are not met. This is because expectations are checked when
the MockFunction is garbage-collected or when Mock::VerifyAndClear(&mockObject)
is called. The garbage collection happens when all tests finish. At that time,
there's a message printed in console, but no test failure.

Therefore, I am taking a different approach to MockFunction. I am keeping a
reference to every MockFunction that I create and then calling
Mock::VerifyAndClear() on these objects when a test case finishes. The best
place to store these references is in PaymentRequestTestBase persistently.
Persistence must be used because ScriptFunction is garbage collected, but unit
test cases are not.

See PaymentRequestTestBase.h/cpp for the new implementation.

+public:
+    static v8::Local<v8::Function> noExpectations(ScriptState*);
+    static v8::Local<v8::Function> expectCall(ScriptState*);
+    static v8::Local<v8::Function> expectNoCall(ScriptState*);
+
+private:
+    explicit MockFunction(ScriptState*);
+
+    MOCK_METHOD1(call, ScriptValue(ScriptValue));
+};
+
+} // namespace blink
+
+#endif // MockFunction_h