Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 20488: Experimental: introduce a simple way to avoid generating jumps to... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: introduce a simple way to avoid generating jumps to jumps for empty merge code and to avoid duplicating merge code. Use the equality predicate on virtual frames to determine if a forward-jump frame equals the entry frame for a block, or if a pair of forward-jump frames are equal. Committed: http://code.google.com/p/v8/source/detail?r=1310

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -31 lines) Patch
M src/jump-target-ia32.cc View 1 chunk +77 lines, -23 lines 1 comment Download
M src/virtual-frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/virtual-frame.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/virtual-frame-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/virtual-frame-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-19 09:32:23 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/20488/diff/1/4 File src/jump-target-ia32.cc (right): http://codereview.chromium.org/20488/diff/1/4#newcode133 Line 133: void JumpTarget::Bind(int mergable_elements) { I don't know ...
11 years, 10 months ago (2009-02-19 09:49:09 UTC) #2
Mads Ager (chromium)
11 years, 10 months ago (2009-02-19 09:59:50 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698