third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-no-drag-n-drop.html - Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-no-drag-n-drop.html

Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Selecting with shift+drag results in unexpected drag-n-drop Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <p>This test ensures drag-n-drop does not start when extending an existing selec ting with shift + mouse drag, starting over a #text.</p>

	5 <span style='font-size: 50px; padding: 10px;'>hello world</span>

	6 <script>

	7 test(function() {

	8 var span = document.getElementsByTagName('span')[0];

	9 span.focus();

	10

	11 var dragStartCount = 0;

	12 document.addEventListener('dragstart', function (event) { dragStartCount++; });

	13

	14 if (!window.testRunner \|\| !window.eventSender)
	yosin_UTC9 2016/06/27 04:21:50 How about: assert_not_equals(window.testRunner, u How about: assert_not_equals(window.testRunner, undefined, 'requires testRunner'); assert_not_equals(window.eventSender, undefined, 'requires eventSender'); to get rid of if-statement and reduce indentation. tonikitoo 2016/06/27 15:08:15 Done. Show quoted text On 2016/06/27 04:21:50, Yosi_UTC9 wrote: > How about: > > assert_not_equals(window.testRunner, undefined, 'requires testRunner'); > assert_not_equals(window.eventSender, undefined, 'requires eventSender'); > > to get rid of if-statement and reduce indentation. Done.
	15 document.write('This test requires eventSender');

	16 else {

	17 testRunner.dumpAsText();
	yosin_UTC9 2016/06/27 04:21:50 We don't need to have \|testRunner.dumpAsText()\| fo We don't need to have \|testRunner.dumpAsText()\| for testharness.js tonikitoo 2016/06/27 15:08:15 Done. Show quoted text On 2016/06/27 04:21:50, Yosi_UTC9 wrote: > We don't need to have \|testRunner.dumpAsText()\| for testharness.js Done.
	18

	19 var y = span.offsetTop + span.offsetHeight / 2;

	20 eventSender.mouseMoveTo(span.offsetLeft + 5, y);

	21 eventSender.mouseDown();

	22 eventSender.leapForward(200);

	23 eventSender.mouseUp();

	24

	25 eventSender.mouseMoveTo(span.offsetLeft + span.offsetWidth / 4, y);

	26 eventSender.mouseDown(0, ['shiftKey']);

	27 eventSender.leapForward(200);

	28 eventSender.mouseUp();

	29

	30 eventSender.mouseMoveTo(span.offsetLeft + span.offsetWidth / 2, y);

	31 eventSender.mouseDown(0, ['shiftKey']);

	32 eventSender.leapForward(200);

	33 eventSender.mouseMoveTo(span.offsetLeft + span.offsetWidth, y);

	34 eventSender.leapForward(200);

	35 eventSender.mouseUp();

	36

	37 assert_equals(dragStartCount, 0);

	38

	39 span.parentNode.removeChild(span);
	yosin_UTC9 2016/06/27 04:21:51 \|span.remove()\| is shorter. BTW, you don't need to \|span.remove()\| is shorter. BTW, you don't need to remove SPAN element. If you have \|<div id="log"></div>\| tonikitoo 2016/06/27 15:08:15 Done. Show quoted text On 2016/06/27 04:21:51, Yosi_UTC9 wrote: > \|span.remove()\| is shorter. BTW, you don't need to remove SPAN element. > If you have \|<div id="log"></div>\| Done.
	40 }

	41 });

	42 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html » ('j') | no next file with comments »